Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fauna examples to support new FAUNA_DB_DOMAIN environment variable #38434

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Update Fauna examples to support new FAUNA_DB_DOMAIN environment variable #38434

merged 3 commits into from
Jul 13, 2022

Conversation

trevor-fauna
Copy link
Contributor

Documentation / Examples

  • [] Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jul 7, 2022
@balazsorban44
Copy link
Member

Maybe this example should be deprecated in favor of with-fauna: https://github.com/vercel/next.js/tree/canary/examples/with-fauna

@trevor-fauna
Copy link
Contributor Author

Maybe this example should be deprecated in favor of with-fauna: https://github.com/vercel/next.js/tree/canary/examples/with-fauna

I'd consider that outside of the scope of this change, which is just to bring the current examples up to parity. That said, the cookie example is slightly different as it's accepting the authN/authZ context from an upstream request and passing that along, whereas with-fauna just has it baked into the deployed infra.

kakadiadarpan
kakadiadarpan previously approved these changes Jul 13, 2022
ijjk
ijjk previously approved these changes Jul 13, 2022
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit b9ad4aa into vercel:canary Jul 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants