Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about standalone + runtimeConfig caveat #38532

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Add note about standalone + runtimeConfig caveat #38532

merged 3 commits into from
Jul 11, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 11, 2022

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

x-ref: #38119

@ijjk @styfle
Apply suggestions from code review
35d2db2 
Co-authored-by: Steven <steven@ceriously.com>
@ijjk ijjk requested a review from styfle July 11, 2022 21:13
@kodiakhq kodiakhq bot merged commit 1c1fbeb into vercel:canary Jul 11, 2022
@ijjk ijjk deleted the docs/standalone-runtime-config branch July 11, 2022 21:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @styfle