Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update with-service-worker example #38670

Merged
merged 2 commits into from
Jul 18, 2022
Merged

chore: update with-service-worker example #38670

merged 2 commits into from
Jul 18, 2022

Conversation

balazsorban44
Copy link
Member

Fixes #38613

Given navigator.serviceWorker has ~96% support in browsers, also removed the check for "serviceWorker" in navigator.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jul 15, 2022
@kodiakhq kodiakhq bot merged commit bc9a4da into canary Jul 18, 2022
@kodiakhq kodiakhq bot deleted the fix/issue-38613 branch July 18, 2022 20:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service worker example not working with window load event
2 participants