Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update typescript.md #38717

Merged
merged 4 commits into from
Jul 25, 2022
Merged

docs: update typescript.md #38717

merged 4 commits into from
Jul 25, 2022

Conversation

nyedidikeke
Copy link
Contributor

@nyedidikeke nyedidikeke commented Jul 16, 2022

"You SHOULD NOT remove nor edit it" in place of "You cannot remove it or edit it".
Rational:

  • It is a strong recommendation; not a weak possibility.
  • Both actions have a negative connotation; as such, it is appropriate to use "nor".

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

"You [SHOULD NOT](https://datatracker.ietf.org/doc/html/rfc2119#section-4) remove nor edit it" in place of "You cannot remove it or edit it".
Rational:
- It is a strong recommendation; not a weak possibility.
- Both actions have a negative connotation; as su, is appropriate to us _nor_ in place of _or_.
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually “nor” follows “neither”

I think the existing sentence is correct as is, because according to Bryan Garner, “the initial negative carries through to all the enumerated elements”

balazsorban44
balazsorban44 previously approved these changes Jul 17, 2022
@balazsorban44 balazsorban44 self-requested a review July 17, 2022 11:08
@balazsorban44 balazsorban44 dismissed their stale review July 17, 2022 11:09

I saw there was a comment made, dismissing my approval.

@nyedidikeke nyedidikeke requested a review from styfle July 24, 2022 23:30
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change!

@kodiakhq kodiakhq bot merged commit 413d35b into vercel:canary Jul 25, 2022
@leonaves
Copy link

This file should not be committed

It's literally added and committed automatically in the initial commit when you run npx create-next-app@latest --typescript ?

@nyedidikeke nyedidikeke deleted the patch-1 branch July 29, 2022 11:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants