-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update typescript.md #38717
docs: update typescript.md #38717
Conversation
"You [SHOULD NOT](https://datatracker.ietf.org/doc/html/rfc2119#section-4) remove nor edit it" in place of "You cannot remove it or edit it". Rational: - It is a strong recommendation; not a weak possibility. - Both actions have a negative connotation; as su, is appropriate to us _nor_ in place of _or_.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually “nor” follows “neither”
I think the existing sentence is correct as is, because according to Bryan Garner, “the initial negative carries through to all the enumerated elements”
I saw there was a comment made, dismissing my approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change!
It's literally added and committed automatically in the initial commit when you run |
"You SHOULD NOT remove
nor edit it" in place of "You cannot remove it or edit it".Rational:
Both actions have a negative connotation; as such, it is appropriate to use "nor".Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
pnpm lint