Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with-emotion-swc to use TypeScript #38744

Merged
merged 5 commits into from
Jul 18, 2022
Merged

Update with-emotion-swc to use TypeScript #38744

merged 5 commits into from
Jul 18, 2022

Conversation

JohnDaly
Copy link
Contributor

@JohnDaly JohnDaly commented Jul 17, 2022 •
edited

Updating the with-emotion-swc example to use TypeScript

  • Updated the dependencies
  • Setting @emotion/react as the jsxImportSource, for better TypeScript support
  • Adding prop types for Animated component

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jul 17, 2022
balazsorban44
balazsorban44 previously requested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, minor comment

@ijjk ijjk merged commit f544a90 into vercel:canary Jul 18, 2022
@JohnDaly JohnDaly deleted the update/with-emotion-swc-to-typescript branch July 18, 2022 18:43
@trevor-fauna trevor-fauna mentioned this pull request Jul 19, 2022
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@balazsorban44 balazsorban44 balazsorban44 left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohnDaly @balazsorban44 @ijjk