Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about test-trace artifact to test readme #38770

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Add note about test-trace artifact to test readme #38770

merged 2 commits into from
Jul 18, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 18, 2022

This adds a note about our test trace artifact which can be leveraged for debugging CI failures.

x-ref: https://github.com/vercel/next.js/actions/runs/2678140048

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Jul 18, 2022
@ijjk ijjk marked this pull request as ready for review July 18, 2022 17:46
@ijjk ijjk requested a review from wyattjoh July 18, 2022 17:46
wyattjoh
wyattjoh previously approved these changes Jul 18, 2022
View reviewed changes
@ijjk ijjk merged commit f004868 into vercel:canary Jul 18, 2022
@ijjk ijjk deleted the docs/test-trace-info branch July 18, 2022 18:01
@trevor-fauna trevor-fauna mentioned this pull request Jul 19, 2022
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wyattjoh wyattjoh wyattjoh approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @wyattjoh