Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: convert with-dynamic-import to TypeScript #38844

Merged
merged 4 commits into from
Jul 21, 2022
Merged

chore: convert with-dynamic-import to TypeScript #38844

merged 4 commits into from
Jul 21, 2022

Conversation

balazsorban44
Copy link
Member

Closes #38806

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jul 20, 2022
@kodiakhq kodiakhq bot merged commit adf40a6 into canary Jul 21, 2022
@kodiakhq kodiakhq bot deleted the fix/issue-38806 branch July 21, 2022 02:22
@NOUIY NOUIY mentioned this pull request Aug 12, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with-dynamic-import example and related docs to be updated to use Typescript
2 participants
@balazsorban44 @ijjk