Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): convert with-stitches to TS #38892

Merged
merged 6 commits into from
Jul 22, 2022
Merged

chore(example): convert with-stitches to TS #38892

merged 6 commits into from
Jul 22, 2022

Conversation

nix6839
Copy link
Contributor

@nix6839 nix6839 commented Jul 21, 2022

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

In contributing doc:

Example directories should not be prefixed with with-

Should I remove the prefix with- from the directory name?

@ijjk ijjk added the examples Issue/PR related to examples label Jul 21, 2022
@ijjk
Copy link
Member

ijjk commented Jul 22, 2022

Thanks!

@ijjk ijjk merged commit 4d8d99e into vercel:canary Jul 22, 2022
@nix6839 nix6839 deleted the with-stitches-to-ts branch July 24, 2022 12:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants