Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert cms-agilitycms example to TypeScript #38976

Merged
merged 8 commits into from
Jul 27, 2022
Merged

Convert cms-agilitycms example to TypeScript #38976

merged 8 commits into from
Jul 27, 2022

Conversation

maxproske
Copy link
Contributor

Converted cms-agilitycms example to TypeScript to match Contribution docs.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jul 24, 2022
balazsorban44
balazsorban44 previously approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Minor comment, but looks good.

@maxproske @balazsorban44
Update examples/cms-agilitycms/environment.d.ts
cfe01db 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@maxproske
Copy link
Contributor Author

@balazsorban44 Good call. Fixed!

balazsorban44
balazsorban44 previously approved these changes Jul 26, 2022
View reviewed changes
@maxproske @ijjk
Update examples/cms-agilitycms/pages/api/preview.ts
c57f23f 
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@maxproske maxproske requested a review from ijjk July 27, 2022 19:04
ijjk
ijjk approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit e955850 into vercel:canary Jul 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@styfle styfle Awaiting requested review from styfle styfle is a code owner

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxproske @balazsorban44 @ijjk