Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing glamor style as default #39

Merged
merged 1 commit into from Oct 25, 2016
Merged

Exposing glamor style as default #39

merged 1 commit into from Oct 25, 2016

Conversation

impronunciable
Copy link
Contributor

allowing different ways to import the css helpers

css.default[key] = css[key]
}
})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use ES6 exports

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-exporting a module doesn't work with babel, so it should be ok for now.
babel/babel-loader#195

@nkzawa nkzawa merged commit 1952a47 into master Oct 25, 2016
@nkzawa nkzawa deleted the add/css-default-export branch October 25, 2016 06:57
@nkzawa nkzawa mentioned this pull request Oct 25, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants