Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default gitignore templates #39051

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Update default gitignore templates #39051

merged 1 commit into from
Jul 27, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 27, 2022

This updates all of gitignore templates to include next-env.d.ts and updates the example ones to the current template content as well.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

Closes: #39026
Closes: #38541

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue/PR related to examples created-by: Next.js team PRs by the Next.js team labels Jul 27, 2022
@ijjk ijjk marked this pull request as ready for review July 27, 2022 00:49
@ijjk ijjk merged commit 0ab6ad5 into vercel:canary Jul 27, 2022
@ijjk ijjk deleted the update/gitignore-templates branch July 27, 2022 13:50
@balazsorban44 balazsorban44 mentioned this pull request Jul 28, 2022
Closed
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @styfle