Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use if..elif..else in docker examples #39072

Merged
merged 3 commits into from
Jul 27, 2022
Merged

fix: use if..elif..else in docker examples #39072

merged 3 commits into from
Jul 27, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Jul 27, 2022 •
edited by ijjk

Fixes #39062
Closes: #39074
Closes: #38971

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jul 27, 2022
ijjk
ijjk approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit 0a781dd into canary Jul 27, 2022
@ijjk ijjk deleted the fix/issue-39062 branch July 27, 2022 14:54
@randallmlough randallmlough mentioned this pull request Jul 27, 2022
Closed
1 task
@c-ehrlich c-ehrlich mentioned this pull request Aug 20, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker build RUN yarn build Error: Call retries were exceeded
2 participants
@balazsorban44 @ijjk