Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/evm-multichain-dapp #39206

Merged
merged 12 commits into from Sep 30, 2022
Merged

Conversation

saurabhburade
Copy link
Contributor

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

The template repository can be found here
Public reviews, and improvement suggestions are welcome!

Supported Blockchains

  1. ETHEREUM
  2. ROPSTEN
  3. RINKEBY
  4. GÖRLI
  5. KOVAN
  6. MATIC
  7. MATIC_TESTNET
  8. FANTOM
  9. FANTOM_TESTNET
  10. XDAI
  11. BSC
  12. BSC_TESTNET
  13. ARBITRUM
  14. ARBITRUM_TESTNET
  15. MOONBEAM_TESTNET
  16. AVALANCHE
    and more

Note

  • This template has the flexibility to seamlessly extend to other EVM Blockchains.
  • It has web3.js and wallet connection modules.
  • It supports blockchain Read and Write functionalities.

@ijjk ijjk added the examples Issue/PR related to examples label Jul 31, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please revert the pnpm-lock.yaml changes, as examples should not modify the lock file.

Can you also address my comments? Make sure you read through https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md to not miss any necessary changes!

examples/evm-multichain-dapp/package.json Outdated Show resolved Hide resolved
examples/evm-multichain-dapp/package.json Outdated Show resolved Hide resolved
examples/evm-multichain-dapp/package.json Outdated Show resolved Hide resolved
examples/evm-multichain-dapp/package.json Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one concern. Can we discuss before merging?

@saurabhburade saurabhburade requested review from balazsorban44 and removed request for huozhi September 30, 2022 14:12
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 92db7f1 into vercel:canary Sep 30, 2022
@saurabhburade
Copy link
Contributor Author

Thank You balazsorban44 for your time & suggestions 🍻.

BowlingX pushed a commit to BowlingX/next.js that referenced this pull request Oct 5, 2022
## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)


The template repository can be found [here](https://github.com/saurabhburade/with-evm-chains)
Public reviews, and improvement suggestions are welcome!
## Supported Blockchains
1. ETHEREUM
2. ROPSTEN
3. RINKEBY
4. GÖRLI
5. KOVAN
6. MATIC
7. MATIC_TESTNET
8. FANTOM
9. FANTOM_TESTNET
10. XDAI
11. BSC
12. BSC_TESTNET
13. ARBITRUM
14. ARBITRUM_TESTNET
15. MOONBEAM_TESTNET
16. AVALANCHE
and more


### Note 
- This template has the flexibility to seamlessly extend to other EVM Blockchains.
- It has web3.js and wallet connection modules.
- It supports blockchain Read and Write functionalities.


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)


The template repository can be found [here](https://github.com/saurabhburade/with-evm-chains)
Public reviews, and improvement suggestions are welcome!
## Supported Blockchains
1. ETHEREUM
2. ROPSTEN
3. RINKEBY
4. GÖRLI
5. KOVAN
6. MATIC
7. MATIC_TESTNET
8. FANTOM
9. FANTOM_TESTNET
10. XDAI
11. BSC
12. BSC_TESTNET
13. ARBITRUM
14. ARBITRUM_TESTNET
15. MOONBEAM_TESTNET
16. AVALANCHE
and more


### Note 
- This template has the flexibility to seamlessly extend to other EVM Blockchains.
- It has web3.js and wallet connection modules.
- It supports blockchain Read and Write functionalities.


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants