Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade example to Docker Compose v2 #39372

Merged
merged 1 commit into from Aug 6, 2022
Merged

chore: upgrade example to Docker Compose v2 #39372

merged 1 commit into from Aug 6, 2022

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Aug 6, 2022

Upgrade the README to use Docker Compose v2, which is faster and shipped by default with Docker Desktop since April.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Aug 6, 2022
@kodiakhq kodiakhq bot merged commit 43a4a8e into vercel:canary Aug 6, 2022
@balazsorban44
Copy link
Member

@dunglas I think this is going to be confusing. See #38505

We should either revert this or mention that this is not going to work by default on Linux.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dunglas @balazsorban44 @leerob @ijjk