Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: broken TypeScript in WordPress example. #39402

Merged
merged 14 commits into from Aug 8, 2022
Merged

Fix: broken TypeScript in WordPress example. #39402

merged 14 commits into from Aug 8, 2022

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Aug 8, 2022

  • chore: add typescript and update deps
  • style: add tsconfig
  • chore: add g.avatar.com domain
  • fix: images domain api url to match with hostname
  • style: convert files to typescript
  • refactor(Avatar): const name for readable purpose
  • refactor: change regex to extract www from url
  • Update next-image domains.
  • Update a few types.
  • Update readme.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Aug 8, 2022
@anthonyshew anthonyshew marked this pull request as ready for review August 8, 2022 17:16
@anthonyshew anthonyshew changed the title Update broken TypeScript in WordPress example. Fix: broken TypeScript in WordPress example. Aug 8, 2022
leerob
leerob previously approved these changes Aug 8, 2022
@leerob
Copy link
Member

leerob commented Aug 8, 2022

Merge conflicts - could you please address? 🙏

@ijjk ijjk merged commit 60c8e5c into vercel:canary Aug 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants