Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): Add 'Sitefinity CMS' Example #39537

Merged
merged 25 commits into from Oct 1, 2022

Conversation

Gebov
Copy link
Contributor

@Gebov Gebov commented Aug 12, 2022

This is an example of how to integrate Sitefinity CMS with next.js

@ijjk ijjk added the examples Issue/PR related to examples label Aug 12, 2022
@Gebov Gebov marked this pull request as ready for review August 12, 2022 13:53
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small comments. Could you also explain what is sitefinity/SitefinityExport.zip? It does not seem to be referenced anywhere. Can we remove it?

examples/cms-sitefinity/README.md Outdated Show resolved Hide resolved
examples/cms-sitefinity/README.md Outdated Show resolved Hide resolved
examples/cms-sitefinity/package.json Outdated Show resolved Hide resolved
examples/cms-sitefinity/pages/_document.tsx Outdated Show resolved Hide resolved
@Gebov
Copy link
Contributor Author

Gebov commented Sep 30, 2022

@balazsorban44 The file sitefinity/SitefinityExport.zip is a CMS specific set of files that when imported into the CMS automatically create the necessary dynamic model for this example to work. An alternative to that file would be an update to the ReadMe with the manual steps to add each dynamic model in the Administration.

@balazsorban44
Copy link
Member

balazsorban44
balazsorban44 previously approved these changes Sep 30, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed some files to keep it as simple as possible. Thanks for the PR!

balazsorban44
balazsorban44 previously approved these changes Sep 30, 2022
@balazsorban44 balazsorban44 changed the title Add 'Sitefinity CMS' Example chore(examples): Add 'Sitefinity CMS' Example Sep 30, 2022
balazsorban44
balazsorban44 previously approved these changes Oct 1, 2022
@balazsorban44 balazsorban44 merged commit ccbc9b8 into vercel:canary Oct 1, 2022
BowlingX pushed a commit to BowlingX/next.js that referenced this pull request Oct 5, 2022
This is an example of how to integrate [Sitefinity CMS
](https://www.progress.com/sitefinity-cms)with next.js

Co-authored-by: Balázs Orbán <info@balazsorban.com>
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
This is an example of how to integrate [Sitefinity CMS
](https://www.progress.com/sitefinity-cms)with next.js

Co-authored-by: Balázs Orbán <info@balazsorban.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants