-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: README doesn't coincide with what is in the example code (pages/_app.js) #39555
Comments
@balazsorban44 I'll be happy to take this one. |
## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) This change is related to issue #39555 PTAL, Thanks Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
Is this issue still open? Seems like the desired changes in the documentation have been made. |
Oh, should i be closing it, since i opened it? |
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
What is the improvement or update you wish to see?
I would like to see the documentation in the README be consistent with what's in the code.
In the next.js/examples/with-redux-thunk README.md, it states:
... The MyApp component is wrapped in a withReduxStore function ...
However, in the code at
pages/_app.js
there is noMyApp
component nor is there awithReduxStore
function, so it's really confusing. I'm guessing that got replaced with the hook in _app.js calleduseStore
??Additionally, it states:
1.) pages/index.js will utilize connect from react-redux ...
which seems wrong, because there's no call to any
connect
function in the actual code.Also the last sentence states:
... then in store.js change (line 19) store.replaceReducer(createNextReducer(initialState)) to store.replaceReducer(createNextReducer).
that also seems wrong because i can't find
store.replaceReducer
anywhere.Is there any context that might help us understand?
Just read the README and try to follow along in the code.
Does the docs page already exist? Please link to it.
https://github.com/vercel/next.js/tree/canary/examples/with-redux-thunk/README.md
The text was updated successfully, but these errors were encountered: