Update Convex Example #39562
Merged
Update Convex Example #39562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcole
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey,
balazsorban44 and
huozhi
as code owners
leerob
approved these changes
Aug 14, 2022
ijjk
approved these changes
Aug 16, 2022
ijjk
pushed a commit
that referenced
this pull request
Aug 19, 2022
This is a followup to #39562 because I realized I made a few mistakes. Remove convex.json file. Developers using the example should generate this on their own by running npx convex init. Switch prettier to a dev dependency. Ignore formatting in Convex generated code while running lint-staged and revert them back to the default generated form (I previously was only ignoring generated code in the main .prettierignore) Change a let to a const cc @thomasballinger Documentation / Examples Make sure the linting passes by running pnpm lint The examples guidelines are followed from our contributing doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes to the Convex example app.
We're using this example app in the Convex quick start (https://docs.convex.dev/quick-start), so I want to make sure we're setting new users up for success.
tsconfig.jsonfor Convex functions)latestDocumentation / Examples
pnpm lint