Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): update with-apivideo #39727

Merged
merged 13 commits into from Oct 20, 2022
Merged

Conversation

MarDi66
Copy link
Contributor

@MarDi66 MarDi66 commented Aug 18, 2022

Documentation / Examples

Hello Next.js 👋🏼

This PR aims to update the previous with-apivideo-uploader example by:

  • Adding others api.video's features
  • Changing the example name to with-apivideo

What's new

In addition to the uploader page, we have added:

  • A videos list page to help the users display their videos to anyone easily
  • A video player page to watch any video from the user's videos list

What do we use

In this example, we use several Next.js features:

  • Routes and dynamic routes
  • API and dynamic API routes
  • SWR

And api.video tools:

  • NodeJS client
  • React player (instead of our Player SDK)
  • TypeScript uploader

Thank's in advance for your review 🙏🏼

@ijjk ijjk added the examples Issue/PR related to examples label Aug 18, 2022
@MarDi66
Copy link
Contributor Author

MarDi66 commented Aug 18, 2022

I see an error in the build test process:
ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up-to-date with packages/next-mdx/package.json

I've already faced this error trying to deploy to Vercel, and the only solution I found was to change the default install command to npm install.

FYI, pnpm i works fine locally.

Any other solution that I can apply (if needed)?

@balazsorban44
Copy link
Member

balazsorban44 commented Sep 29, 2022

Hi @MarDi66 it looks like contributors are not allowed to edit your branch, so I cannot update or even merge this PR. I wanted to bring in the latest canary to see if that fixed pnpm issues. FWIW, examples should not modify the lock file, so please revert that change. Could you make sure that contributors are allowed to make changes? 🙏 Without that, this PR cannot land.

Further, keep in mind if we change or rename the directory, already existing links on the internet might break, but given the example is a few months old only, I think it is reasonable to rename without keeping the old one with a README that points to the new location. 👍

For simplicity's sake, we like to focus examples on the core feature/library they are presenting. Is SWR a vital part of the example? If not, maybe we should strip it, what do you think?

@MarDi66
Copy link
Contributor Author

MarDi66 commented Oct 6, 2022

Hey @balazsorban44 ✌🏼

I've removed the lock file changes and SWR from this PR.
I also invited you to our forked Next.js repo, tell me if he lets you manage this PR the way you want.

Cheers!

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balazsorban44 balazsorban44 changed the title Examples: update with-apivideo chore(examples): update with-apivideo Oct 20, 2022
@balazsorban44 balazsorban44 merged commit 12408a3 into vercel:canary Oct 20, 2022
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
Co-authored-by: Thibault Beyou <37510686+ThibaultBee@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants