Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert with-goober example to TS #39761

Merged
merged 3 commits into from
Aug 21, 2022
Merged

Convert with-goober example to TS #39761

merged 3 commits into from
Aug 21, 2022
+49 −12

Conversation

kasperaamodt
Copy link
Contributor

@kasperaamodt kasperaamodt commented Aug 19, 2022 •
edited
Loading

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from [our contributing doc]

Sorry, something went wrong.

@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 19, 2022
@kasperaamodt
Copy link
Contributor Author

@cristianbote I made a PR that converts the Goober example to TS.

ijjk added 2 commits August 21, 2022 17:44
@ijjk
Merge branch 'canary' into update-goober-example

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
4cd3d09
@ijjk
lint-fix

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
90550a2
ijjk
ijjk approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit bc4d98a into vercel:canary Aug 21, 2022
@kasperaamodt kasperaamodt deleted the update-goober-example branch August 25, 2022 20:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk

@timneutkens timneutkens

@shuding shuding

@leerob leerob

@steven-tey steven-tey

@balazsorban44 balazsorban44

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kasperaamodt @ijjk