Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary type reference in Vitest example #39819

Merged
merged 2 commits into from Aug 22, 2022

Conversation

michaeloliverx
Copy link
Contributor

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

The Vitest docs state that /// <reference types="vitest" /> is only required when importing defineConfig from vite.

using defineConfig from vitest/config you should follow this:

import { defineConfig } from 'vitest/config'

export default defineConfig({
  test: {
    // ...
  },
})

@ijjk ijjk added the examples Issue/PR related to examples label Aug 22, 2022
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit c172d46 into vercel:canary Aug 22, 2022
@michaeloliverx michaeloliverx deleted the remove-unnecessary-type-reference branch August 22, 2022 14:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants