New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add with-xata
example
#39864
Add with-xata
example
#39864
Conversation
2785652
to
1254d72
Compare
8db2abb
to
a604b91
Compare
a604b91
to
192f061
Compare
aa6d2dc
to
f79e310
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good!
title: 'Next.js with-xata', | ||
description: 'Run Next.js with Xata with this awesome template', | ||
image: | ||
process.env.NODE_ENV === 'development' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because OG:Image requires it to be absolute urls, pointing it to localhost on dev makes it easier to test a new image, I thought it was a nice addition to whoever bases on this template to build something.
But absolutely not needed
I can remove it if you prefer.
e95be49
to
c0f0233
Compare
Co-authored-by: Lee Robinson <me@leerob.io>
c0f0233
to
49282ae
Compare
Heeeey, folks! Gentle little poke on this. Anything I can do to help it get merged?? 🙏 |
This Pull Request adds a `with-xata` example to use [Xata](https://xata.io) as the data layer of a Next.js app. ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples) Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
This Pull Request adds a
with-xata
example to use Xata as the data layer of a Next.js app.Documentation / Examples
pnpm lint