Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with-xata example #39864

Merged
merged 14 commits into from Sep 29, 2022
Merged

Add with-xata example #39864

merged 14 commits into from Sep 29, 2022

Conversation

atilafassina
Copy link
Contributor

This Pull Request adds a with-xata example to use Xata as the data layer of a Next.js app.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good!

examples/with-xata/README.md Outdated Show resolved Hide resolved
examples/with-xata/package.json Outdated Show resolved Hide resolved
title: 'Next.js with-xata',
description: 'Run Next.js with Xata with this awesome template',
image:
process.env.NODE_ENV === 'development'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because OG:Image requires it to be absolute urls, pointing it to localhost on dev makes it easier to test a new image, I thought it was a nice addition to whoever bases on this template to build something.

But absolutely not needed

I can remove it if you prefer.

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Sep 5, 2022
@atilafassina atilafassina force-pushed the xata-example branch 2 times, most recently from e95be49 to c0f0233 Compare September 9, 2022 11:08
@atilafassina
Copy link
Contributor Author

Heeeey, folks!

Gentle little poke on this. Anything I can do to help it get merged?? 🙏

@kodiakhq kodiakhq bot merged commit 2fa33b3 into vercel:canary Sep 29, 2022
BowlingX pushed a commit to BowlingX/next.js that referenced this pull request Oct 5, 2022
This Pull Request adds a `with-xata` example to use [Xata](https://xata.io) as the data layer of a Next.js app.

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue/PR related to examples type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants