Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runLintCheck during build #39883

Merged
merged 1 commit into from Aug 24, 2022
Merged

Fix runLintCheck during build #39883

merged 1 commit into from Aug 24, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 24, 2022

Follow-up to #39872 this fixes a check in runLintCheck causing setup to start during build and adds a regression test.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 24, 2022
@ijjk ijjk marked this pull request as ready for review August 24, 2022 03:35
@ijjk ijjk merged commit 88916fb into vercel:canary Aug 24, 2022
@ijjk ijjk deleted the fix/build-lint-check branch August 24, 2022 03:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ijjk