Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing e2e getServerSideProps test #39885

Merged
merged 1 commit into from Aug 24, 2022
Merged

Fix failing e2e getServerSideProps test #39885

merged 1 commit into from Aug 24, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 24, 2022

After the fix was landed for _error being used even when it's a serverless function this test no longer shows the default Vercel error page.

Fixes: https://github.com/vercel/next.js/runs/7985910009?check_suite_focus=true

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Aug 24, 2022
@ijjk ijjk marked this pull request as ready for review August 24, 2022 03:40
@ijjk ijjk merged commit 9d4bb49 into vercel:canary Aug 24, 2022
@ijjk ijjk deleted the test/e2e-getserversideprops branch August 24, 2022 03:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ijjk