Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing VERCEL_CLI_VERSION env for deploy tests #39946

Merged
merged 1 commit into from Aug 25, 2022
Merged

Fix passing VERCEL_CLI_VERSION env for deploy tests #39946

merged 1 commit into from Aug 25, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 25, 2022

The quotes around the env were being passed literally breaking usage of the env variable so this removes them.

x-ref: slack thread

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Aug 25, 2022
@ijjk ijjk merged commit 5e5d56c into vercel:canary Aug 25, 2022
@ijjk ijjk deleted the test/env-vercel-cli-version branch August 25, 2022 19:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @huozhi