Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix next/future/image incorrectly warning for fill + blur #39986

Merged
merged 3 commits into from Aug 26, 2022
Merged

Fix next/future/image incorrectly warning for fill + blur #39986

merged 3 commits into from Aug 26, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Aug 26, 2022 •
edited

This warning was incorrectly printed when fill and placeholder="blur" were used together:

Image with src "/test.jpg" is smaller than 40x40. Consider removing the "placeholder='blur'" property to improve performance.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 26, 2022
@styfle styfle changed the title Fix next/future/image incorrectly warning for fill Fix next/future/image incorrectly warning for fill + blur Aug 26, 2022
@styfle styfle marked this pull request as ready for review August 26, 2022 20:36
@ijjk ijjk merged commit 6a65dc5 into canary Aug 26, 2022
@ijjk ijjk deleted the fix-future-image-fill-warning branch August 26, 2022 21:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@styfle @ijjk