Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect build log for moduleResolution #39991

Merged
merged 2 commits into from Aug 27, 2022
Merged

Fix incorrect build log for moduleResolution #39991

merged 2 commits into from Aug 27, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 26, 2022

Removes extra log shown when checking moduleResolution in tsconfig.json and adds regression test.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 26, 2022
@ijjk ijjk marked this pull request as ready for review August 26, 2022 23:47
@ijjk ijjk merged commit f6c96e0 into vercel:canary Aug 27, 2022
@ijjk ijjk deleted the fix/tsconfig-update branch August 27, 2022 00:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @huozhi