[docs] Improve documentation around pageExtensions
#40039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1b61d1f.
leerob
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
padmaia and
balazsorban44
as code owners
leerob
changed the title
pageExtensions"pageExtensions
leerob
commented
Aug 28, 2022
|
I think this is ready cc @balazsorban44 |
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Co-authored-by: Balázs Orbán <info@balazsorban.com>
|
This is now good to merge @balazsorban44 🙏 |
balazsorban44
approved these changes
Sep 30, 2022
BowlingX
pushed a commit
to BowlingX/next.js
that referenced
this pull request
Oct 5, 2022
Reverts vercel#40016. `pageExtensions` is not frequently used – as is mostly a workaround until the Layouts RFC lands. Thus, it doesn't make sense to place a note on the Middleware page and expect readers to need to connect the dots and understand `pageExtensions`. Further, the example docs linked could be more specific about Middleware to prevent this confusion. I will also make that change here. Co-authored-by: Balázs Orbán <info@balazsorban.com>
Kikobeats
pushed a commit
to Kikobeats/next.js
that referenced
this pull request
Oct 24, 2022
Reverts vercel#40016. `pageExtensions` is not frequently used – as is mostly a workaround until the Layouts RFC lands. Thus, it doesn't make sense to place a note on the Middleware page and expect readers to need to connect the dots and understand `pageExtensions`. Further, the example docs linked could be more specific about Middleware to prevent this confusion. I will also make that change here. Co-authored-by: Balázs Orbán <info@balazsorban.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40016.
pageExtensionsis not frequently used – as is mostly a workaround until the Layouts RFC lands. Thus, it doesn't make sense to place a note on the Middleware page and expect readers to need to connect the dots and understandpageExtensions.Further, the example docs linked could be more specific about Middleware to prevent this confusion. I will also make that change here.