Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(image): Use hook inside of function component #40096

Merged
merged 4 commits into from Aug 30, 2022
Merged

Conversation

Dueen
Copy link
Contributor

@Dueen Dueen commented Aug 30, 2022

The example broke the Rules of Hooks by calling the hook outside of the function component.

styfle
styfle previously approved these changes Aug 30, 2022
ijjk
ijjk previously approved these changes Aug 30, 2022
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@ijjk ijjk merged commit b760c8d into vercel:canary Aug 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants