Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flakey tsconfig test #40105

Merged
merged 1 commit into from Aug 30, 2022
Merged

Update flakey tsconfig test #40105

merged 1 commit into from Aug 30, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 30, 2022

Updates this test to not rely on waitFor as the amount of time it takes to write the tsconfig.json can vary so we should use check instead.

Fixes: #39902 (comment)

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Aug 30, 2022
@ijjk ijjk merged commit c89e25e into vercel:canary Aug 30, 2022
@ijjk ijjk deleted the test/flakey-tsconfig-test branch August 30, 2022 17:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ijjk