-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update get-static-paths.md #40205
Conversation
add explanation when client-side page transition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked the source code and implementation details to back your theory?
@SukkaW Should I check the source code and identify why it happens? |
You could also use GitHub's blame to find who, when, and where ("where" means in which PR) that this documentation is initially made: It documents this behavior for a reason. And personally, I didn't notice Next.js has made some changes toward this part recently (thus I believe the behavior may not change). |
Thanks for your comment! Maybe I haven't yet understood what you tell me. You mean that, there has to be a reason that document don't mention client-side page transition, right? If so, I'll check out git logs related to this page. |
Co-authored-by: Lee Robinson <me@leerob.io>
@leerob Well, do you think this behavior is not a bug but a spec?
I thought so because you gave me a polish, but I'm a bit worried that this behavior is not intended by Next.js. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this behavior is expected and sounds good to document, thanks for the PR!
@ijjk |
@ijjk
|
I'm not sure of a specific discussion to link to although could go back to the original RFCs, this has been the expected behavior since |
I found that
fallback: true
behaves likefallback: blocking
when client-side page transition, but document doesn't mention the behavior.I tried following.
await setTimeout(10000)
)next build && next start
, notnext dev
getServerSideProps document explains about client-side page transition.
https://nextjs.org/docs/basic-features/data-fetching/get-server-side-props#when-does-getserversideprops-run
On the other hand, getStaticPaths didn't explain this behavior, so I added it.
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
pnpm lint