Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "negative matcher" documentation #40282

Merged
merged 4 commits into from Sep 13, 2022
Merged

Added "negative matcher" documentation #40282

merged 4 commits into from Sep 13, 2022

Conversation

steven-tey
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

styfle
styfle previously approved these changes Sep 6, 2022
View reviewed changes
ijjk
ijjk reviewed Sep 6, 2022
View reviewed changes
docs/advanced-features/middleware.md Outdated
@@ -88,6 +88,22 @@ export const config = {
}
```

You can also create a "negative matcher" that matches all paths except for certain paths:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expand this to say full regex matching can be used including negative lookaheads like this

@ijjk ijjk merged commit f33c23c into canary Sep 13, 2022
@ijjk ijjk deleted the steven-tey-patch-2 branch September 13, 2022 01:26
larssbr
larssbr reviewed Sep 13, 2022
View reviewed changes
docs/advanced-features/middleware.md
* - static (static files)
* - favicon.ico (favicon file)
*/
'/((?!api|static|favicon.ico).*)',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I exclude the homepage "/" from the matches?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@larssbr larssbr larssbr left review comments

@ijjk ijjk ijjk approved these changes

@styfle styfle styfle left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@steven-tey @styfle @larssbr @ijjk