Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change image sizes docs to use em instead of px #40288

Merged
merged 1 commit into from Sep 6, 2022
Merged

Change image sizes docs to use em instead of px #40288

merged 1 commit into from Sep 6, 2022

Conversation

atcastle
Copy link
Collaborator

@atcastle atcastle commented Sep 6, 2022

This PR is a minor change to the image docs (next/image and next/future/image). The example sizes media queries are switched from em to px for readability.

@ijjk ijjk added area: documentation created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora labels Sep 6, 2022
@kodiakhq kodiakhq bot merged commit 815abc5 into vercel:canary Sep 6, 2022
styfle
styfle reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also use max-width instead since that will allow you to write sizes left to right as smallest to largest size

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle left review comments

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atcastle @styfle @ijjk