Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove legacy mobx example #40304

Merged
merged 3 commits into from Sep 14, 2022
Merged

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Sep 7, 2022

Info

This PR merges with-mobx-lite into with-mobx. After that we will migrate with-mobx to typescript.

Context

As discussed in #40302 (comment) we are going to merge the mobx examples.

#40302

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Sep 7, 2022
balazsorban44
balazsorban44 previously approved these changes Sep 8, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balazsorban44
Copy link
Member

balazsorban44 commented Sep 13, 2022

@HaNdTriX could you have a look at the merge conflict so we can merge this? 🙏

# Conflicts:
#	examples/with-mobx-state-tree/components/SampleComponent.js
@kodiakhq kodiakhq bot merged commit 155a4d5 into vercel:canary Sep 14, 2022
@HaNdTriX HaNdTriX deleted the examples/mobx-merge branch September 14, 2022 08:40
@HaNdTriX
Copy link
Contributor Author

Sorry for my late response!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants