Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update react-remove-properties example #40307

Merged
merged 2 commits into from Sep 7, 2022
Merged

[Docs] Update react-remove-properties example #40307

merged 2 commits into from Sep 7, 2022

Conversation

Will956
Copy link
Contributor

@Will956 Will956 commented Sep 7, 2022 •
edited

Hi 馃憢

Based on https://nextjs.org/docs/advanced-features/compiler#remove-react-properties, this is not experimental but lives under compiler now.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Sep 7, 2022
ijjk
ijjk approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 34fa5f8 into vercel:canary Sep 7, 2022
This was referenced Sep 29, 2022
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2022
Open
@jackromo888 jackromo888 mentioned this pull request Sep 30, 2022
Open
@NOUIY NOUIY mentioned this pull request Sep 30, 2022
Open
This was referenced Sep 30, 2022
Open
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
@Will956 Will956 deleted the patch-1 branch November 4, 2022 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Will956 @ijjk