Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix middleware path #40340

Merged
merged 3 commits into from Sep 8, 2022
Merged

docs: fix middleware path #40340

merged 3 commits into from Sep 8, 2022

Conversation

Kikobeats
Copy link
Member

Hello,

Just update the docs to be aligned with the current middleware implementation 馃檪

SukkaW
SukkaW suggested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@SukkaW SukkaW left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO the original wording is still correct and reflects the current implementation?

E.g. I can have src/middleware.ts alongside src/pages/, and middleware.ts and pages/ are both at the src level.

@ijjk @balazsorban44
Apply suggestions from code review
cfa3f6b 
Co-authored-by: Bal谩zs Orb谩n <info@balazsorban.com>
@kodiakhq kodiakhq bot merged commit a234abf into vercel:canary Sep 8, 2022
@Kikobeats Kikobeats deleted the patch-1 branch September 9, 2022 12:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SukkaW SukkaW SukkaW requested changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kikobeats @balazsorban44 @ijjk @SukkaW