Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix examples #40395

Merged
merged 2 commits into from Sep 9, 2022
Merged

chore: fix examples #40395

merged 2 commits into from Sep 9, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Sep 9, 2022 •
edited

Closes #40366

Rebass is not dependent on styled-components anymore. See: https://rebassjs.org/migrating/#v4-breaking-changes

Closes #40367

Document has been converted (#39871) from class, so this.props threw an error.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Sep 9, 2022
@balazsorban44 balazsorban44 changed the title chore: simplify with-rebass example chore: fix examples Sep 9, 2022
@balazsorban44 balazsorban44 merged commit 13e423c into canary Sep 9, 2022
@balazsorban44 balazsorban44 deleted the fix/issue-40366 branch September 9, 2022 13:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with-strict-csp example doesn't run with-rebass example's _document.js does nothing
2 participants
@balazsorban44 @ijjk