Fix mdx docs #40402
Merged
Fix mdx docs #40402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrjohn
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
padmaia,
leerob and
balazsorban44
as code owners
balazsorban44
previously requested changes
Sep 9, 2022
There was a problem hiding this comment.
That sounds correct since @next/mdx marks it as a peer dependency:
next.js/packages/next-mdx/package.json
Line 12 in 13e423c
Could you update this file as well? 🙏:
https://github.com/vercel/next.js/blob/canary/packages/next-mdx/readme.md
ijjk
approved these changes
Sep 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation / Examples
pnpm lintThe MDX guide is missing
@mdx-js/reactas a required dependency in the setup section.