Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use link: instead of file: in CONTRIBUTING.md #40510

Merged
merged 1 commit into from Sep 13, 2022

Conversation

balazsorban44
Copy link
Member

Closes #40497

Ref: https://pnpm.io/cli/link, https://stackoverflow.com/a/70266777

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@balazsorban44 balazsorban44 merged commit baf6046 into canary Sep 13, 2022
@balazsorban44 balazsorban44 deleted the fix/issue-40497 branch September 13, 2022 10:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: contributing.md gives incorrect pnpm lockfile syntax for local file
1 participant