Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove extraneous FallbackComponent prop from error boundary docs #40785

Merged
merged 2 commits into from Sep 22, 2022

Conversation

philippbosch
Copy link
Contributor

It looks like the code snippet was copied over from https://github.com/bvaughn/react-error-boundary but the ErrorBoundary component on this docs page does not have a FallbackComponent prop but renders the error message content itself.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

It looks like the code snippet was copied over from https://github.com/bvaughn/react-error-boundary but the `ErrorBoundary` component on this docs page does not have a `FallbackComponent` prop but renders the error message content itself.
@ijjk ijjk merged commit f16992a into vercel:canary Sep 22, 2022
@philippbosch philippbosch deleted the patch-1 branch September 22, 2022 18:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants