Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open deploy link in new window for examples #40804

Merged
merged 3 commits into from Sep 22, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 22, 2022

Let's open the deploy link in a new window so the link isn't blocked when running an an iframe, such as Stackblitz.

Previously, this would print the following error:

Refused to display 'https://vercel.com/' in a frame because it set 'X-Frame-Options' to 'deny'

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue/PR related to examples created-by: Next.js team PRs by the Next.js team labels Sep 22, 2022
@Nutlope Nutlope self-requested a review September 22, 2022 16:05
@styfle styfle marked this pull request as ready for review September 22, 2022 16:13
@ijjk ijjk merged commit be904d7 into canary Sep 22, 2022
@ijjk ijjk deleted the add-target-href-deploy-examples branch September 22, 2022 16:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants