Tolerate already published error for retrying #40812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
approved these changes
Sep 22, 2022
ijjk
added a commit
that referenced
this pull request
Sep 22, 2022
This updates our `publish-release` script to bypass lerna so that we can retry publishing automatically when there is an npm error and tolerate non-fatal publish errors like already existing published versions. Currently this will only allow publishing a canary release to ensure it is working as expected and in a follow-up we can enable the stable publish handling. Separately we can investigate moving canaries away from `npm` to reduce the number of versions being created there. x-ref: #40812 x-ref: https://github.com/vercel/next.js/actions/runs/3108735543/jobs/5038717354#step:10:2332 x-ref: https://github.com/vercel/next.js/actions/runs/3108335849/jobs/5038069555
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our
publish-nativescript to tolerate the already published npm error so that we can retry publishing on annpmservice error like noticed here. We probably want to migrate away from usinglernafor publishing the non-swc packages as well so that we can retry there as well but will investigate that in a follow-up.x-ref: https://github.com/vercel/next.js/actions/runs/3108335849/jobs/5038069555