Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: with-react-intl update #40975

Closed
mojtaba-hajishah opened this issue Sep 28, 2022 · 3 comments · Fixed by #40999
Closed

Docs: with-react-intl update #40975

mojtaba-hajishah opened this issue Sep 28, 2022 · 3 comments · Fixed by #40999
Labels
examples Issue/PR related to examples

Comments

@mojtaba-hajishah
Copy link

What is the improvement or update you wish to see?

Please update the with-react-intl example to use next 12 and latest version of react-intl.

Is there any context that might help us understand?

Next 12 does not use babel anymore, so we can't configure babel-plugin-formatjs in order to auto-generate ids.
Although it says in the documentations that using .babelrc will fallback next to use babel, but even with that, the example does not work. The extraction and compilation of messages does not work properly.

Does the docs page already exist? Please link to it.

https://github.com/vercel/next.js/tree/canary/examples/with-react-intl
@mojtaba-hajishah mojtaba-hajishah added the Documentation Related to Next.js' official documentation. label Sep 28, 2022
@HaNdTriX HaNdTriX mentioned this issue Sep 28, 2022
Merged
2 tasks
@HaNdTriX
Copy link
Contributor

HaNdTriX commented Sep 28, 2022 •
edited

I have just updated the example inside #40999 can you have a look?
Works with babel on my machine.

@balazsorban44 balazsorban44 added examples Issue/PR related to examples and removed Documentation Related to Next.js' official documentation. labels Sep 29, 2022
@mojtaba-hajishah
Copy link
Author

@HaNdTriX
Thank you for your fast follow up. I think your pull request is not merged yet and is still being reviewed by owners.

ijjk pushed a commit that referenced this issue Sep 30, 2022
@HaNdTriX
chore: update with-react-intl example (#40999)
cae96f2 
## Changes

see commits

## Additional Info

Since this example is quite complex I tried to remove additional noise
(unused type inference).

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

## Related

Closes: #40975
BowlingX pushed a commit to BowlingX/next.js that referenced this issue Oct 5, 2022
@HaNdTriX @BowlingX
chore: update with-react-intl example (vercel#40999)
7debda2 
## Changes

see commits

## Additional Info

Since this example is quite complex I tried to remove additional noise
(unused type inference).

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

## Related

Closes: vercel#40975
Kikobeats pushed a commit to Kikobeats/next.js that referenced this issue Oct 24, 2022
@HaNdTriX @Kikobeats
chore: update with-react-intl example (vercel#40999)
ad37dde 
## Changes

see commits

## Additional Info

Since this example is quite complex I tried to remove additional noise
(unused type inference).

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

## Related

Closes: vercel#40975
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update with-react-intl example HaNdTriX/next.js
3 participants
@HaNdTriX @balazsorban44 @mojtaba-hajishah