Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): Add vanilla-extract example #41061

Merged
merged 4 commits into from Sep 30, 2022
Merged

chore(examples): Add vanilla-extract example #41061

merged 4 commits into from Sep 30, 2022

Conversation

fujiwaracj
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

Response to #29165

Comment on lines 1 to 3
# Next.js + Vanilla Extract Examples

The official vanilla extract repository has provided an example in [examples/next](https://github.com/vanilla-extract-css/vanilla-extract/tree/master/examples/next)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Next.js + Vanilla Extract Examples
The official vanilla extract repository has provided an example in [examples/next](https://github.com/vanilla-extract-css/vanilla-extract/tree/master/examples/next)
# Next.js + Vanilla Extract Examples
The official vanilla-extract repository maintains an example in [examples/next](https://github.com/vanilla-extract-css/vanilla-extract/tree/master/examples/next)

@balazsorban44 balazsorban44 changed the title Add vanilla-extract example chore(examples): Add vanilla-extract example Sep 30, 2022
@kodiakhq kodiakhq bot merged commit f09c3be into vercel:canary Sep 30, 2022
BowlingX pushed a commit to BowlingX/next.js that referenced this pull request Oct 5, 2022
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)


Response to vercel#29165


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)


Response to vercel#29165


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants