Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable prefetch in new router #41086

Merged
merged 6 commits into from Oct 2, 2022
Merged

Temporarily disable prefetch in new router #41086

merged 6 commits into from Oct 2, 2022

Conversation

timneutkens
Copy link
Member

Investigating a navigation issue where navigating gets stuck in some cases.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 1, 2022
@ijjk

This comment was marked as outdated.

Sign in to view
@timneutkens timneutkens marked this pull request as ready for review October 2, 2022 13:49
shuding
shuding previously approved these changes Oct 2, 2022
View reviewed changes
@timneutkens timneutkens merged commit dc45061 into vercel:canary Oct 2, 2022
@timneutkens timneutkens deleted the fix/navigate-stuck branch October 2, 2022 18:35
BowlingX pushed a commit to BowlingX/next.js that referenced this pull request Oct 5, 2022
@timneutkens @balazsorban44 @BowlingX
Temporarily disable prefetch in new router (vercel#41086)
9785d41 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
@timneutkens @balazsorban44 @Kikobeats
Temporarily disable prefetch in new router (vercel#41086)
17c2af7 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@shuding shuding shuding left review comments

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timneutkens @ijjk @shuding @huozhi @balazsorban44