Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class component -> functional component #41089

Merged
merged 2 commits into from Oct 1, 2022
Merged

class component -> functional component #41089

merged 2 commits into from Oct 1, 2022

Conversation

UltiRequiem
Copy link
Contributor

@UltiRequiem UltiRequiem commented Oct 1, 2022 •
edited

easier to read

Documentation / Examples

  • [x ] Make sure the linting passes by running pnpm lint
  • [ x] The "examples guidelines" are followed from our contributing doc

balazsorban44
balazsorban44 previously approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balazsorban44
Copy link
Member

Could you fix the lint issues so we can merge this?

@kodiakhq kodiakhq bot merged commit 1d026ec into vercel:canary Oct 1, 2022
@UltiRequiem
Copy link
Contributor Author

Thanks!

BowlingX pushed a commit to BowlingX/next.js that referenced this pull request Oct 5, 2022
@UltiRequiem @balazsorban44 @BowlingX
class component -> functional component (vercel#41089)
0d01199 
easier to read

## Documentation / Examples

- [x ] Make sure the linting passes by running `pnpm lint`
- [ x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
@UltiRequiem @balazsorban44 @Kikobeats
class component -> functional component (vercel#41089)
b11d2a3 
easier to read

## Documentation / Examples

- [x ] Make sure the linting passes by running `pnpm lint`
- [ x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@UltiRequiem @balazsorban44 @styfle @ijjk