Docs: Fix misleading console.log output example
#41096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p13lgst
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
padmaia,
leerob and
balazsorban44
as code owners
BowlingX
pushed a commit
to BowlingX/next.js
that referenced
this pull request
Oct 5, 2022
The docs have a misleading `console.log` output for the input `process.env` that doesn't display all the variables on edge runtime. The example shows an output of a supposed object with all the environment variables, but it does this when logging a specific variable. ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
Kikobeats
pushed a commit
to Kikobeats/next.js
that referenced
this pull request
Oct 24, 2022
The docs have a misleading `console.log` output for the input `process.env` that doesn't display all the variables on edge runtime. The example shows an output of a supposed object with all the environment variables, but it does this when logging a specific variable. ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs have a misleading
console.logoutput for the inputprocess.envthat doesn't display all the variables on edge runtime. The example shows an output of a supposed object with all the environment variables, but it does this when logging a specific variable.Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples
pnpm lint