Add conflicting app and page error #41099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
requested review from
timneutkens,
shuding,
padmaia and
huozhi
as code owners
huozhi
previously approved these changes
Oct 2, 2022
SukkaW
reviewed
Oct 2, 2022
Co-authored-by: Sukka <isukkaw@gmail.com>
BowlingX
pushed a commit
to BowlingX/next.js
that referenced
this pull request
Oct 5, 2022
This adds a proper error when we detect conflicting app and page paths. Fixes: https://vercel.slack.com/archives/C043ANYDB24/p1664678172389449 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see `contributing.md` Co-authored-by: Sukka <isukkaw@gmail.com>
Kikobeats
pushed a commit
to Kikobeats/next.js
that referenced
this pull request
Oct 24, 2022
This adds a proper error when we detect conflicting app and page paths. Fixes: https://vercel.slack.com/archives/C043ANYDB24/p1664678172389449 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see `contributing.md` Co-authored-by: Sukka <isukkaw@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a proper error when we detect conflicting app and page paths.
Fixes: https://vercel.slack.com/archives/C043ANYDB24/p1664678172389449
Bug
fixes #numbercontributing.md