Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): add webiny cms example #41159

Merged
merged 12 commits into from Oct 5, 2022
Merged

chore(examples): add webiny cms example #41159

merged 12 commits into from Oct 5, 2022

Conversation

endymion1818
Copy link
Contributor

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Oct 4, 2022
balazsorban44
balazsorban44 reviewed Oct 5, 2022
View reviewed changes
pnpm-lock.yaml Outdated Show resolved Hide resolved
balazsorban44
balazsorban44 requested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

React imports are unnecessary unless you access a method like React.useState or types. In most cases, I could not see that, so please remove those imports from files (even if I did not request the change).

@endymion1818
Copy link
Contributor Author

Thanks for your help @balazsorban44, the only thing I wasn't able to do was remove import React from 'react', as it resulted in type errors.

@endymion1818
Copy link
Contributor Author

Hey @balazsorban44, any other way around the react imports thing? I'd really like to get a clear way forward for this PR.

@endymion1818 endymion1818 removed the request for review from huozhi October 5, 2022 13:33
@balazsorban44 balazsorban44 changed the title feature(examples): add webiny cms example chore(examples): add webiny cms example Oct 5, 2022
@balazsorban44
Copy link
Member

You forgot to add a tsconfig.json file, so the IDE reported JSX as an error. I applied some suggestions and fixed up those issues.

@balazsorban44
Copy link
Member

Thanks for the PR!

@balazsorban44 balazsorban44 merged commit d5837e0 into vercel:canary Oct 5, 2022
@balazsorban44
Copy link
Member

Merged manually, since pnpm-lock.yaml was touched (then reverted) and I was not a CODEOWNER.

@endymion1818
Copy link
Contributor Author

Thanks @balazsorban44

BowlingX pushed a commit to BowlingX/next.js that referenced this pull request Oct 5, 2022
@endymion1818 @balazsorban44 @BowlingX
chore(examples): add webiny cms example (vercel#41159)
e34d47d 
## Documentation / Examples

- [X] Make sure the linting passes by running `pnpm lint`
- [X] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

Co-authored-by: Balázs Orbán <info@balazsorban.com>
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
@endymion1818 @balazsorban44 @Kikobeats
chore(examples): add webiny cms example (vercel#41159)
5366ff9 
## Documentation / Examples

- [X] Make sure the linting passes by running `pnpm lint`
- [X] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

Co-authored-by: Balázs Orbán <info@balazsorban.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@styfle styfle Awaiting requested review from styfle styfle is a code owner

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@endymion1818 @balazsorban44 @styfle @ijjk