Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary moduleId option #41160

Merged
merged 1 commit into from Oct 4, 2022
Merged

Remove unnecessary moduleId option #41160

merged 1 commit into from Oct 4, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Oct 4, 2022

deterministic should be already the default option here.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 4, 2022
@ijjk ijjk merged commit d192047 into vercel:canary Oct 4, 2022
@shuding shuding deleted the shu/1jsg branch October 4, 2022 17:42
BowlingX pushed a commit to BowlingX/next.js that referenced this pull request Oct 5, 2022
@shuding @BowlingX
Remove unnecessary moduleId option (vercel#41160)
3fa7732 
`deterministic` should be already the default option here.
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
@shuding @Kikobeats
Remove unnecessary moduleId option (vercel#41160)
193e07c 
`deterministic` should be already the default option here.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shuding @huozhi @ijjk